Skip to content

build: fix coverage build

Rodrigo Muino Tomonari requested to merge github/fork/yhwang/fix-coverage into master

After adding the node_lib target in node.gyp, most of the node source files are moved to that target. When coverage option is enabled, corresponding cflags and ldflags are needed in that target as well. gcovr also needs to check .gcda data for both node and node_lib.

Fixes: https://github.com/nodejs/node/issues/18402

Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports