Skip to content

readline: use Date.now() and move test to parallel

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/patch-readline-timer-now into master

The readline module wants a truthy time while using Timer.now() doesn't necessarily guarantee that early on in the process' life. It also doesn't actually resolve the timing issues experienced in https://github.com/nodejs/node/pull/14681. Instead, this PR fixes the related tests and moves them back to parallel.

This needs a stress test & CI (hence the WIP), but I can't seem to run one from a different repository anymore as used to be possible...

CI: https://ci.nodejs.org/job/node-test-pull-request/12927/ (green) https://ci.nodejs.org/job/node-test-pull-request/12930/ (green) https://ci.nodejs.org/job/node-test-pull-request/12931/ (green) https://ci.nodejs.org/job/node-test-pull-request/12932/ https://ci.nodejs.org/job/node-test-pull-request/12933/ Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1774/ (OS X)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

readline

Merge request reports