Skip to content

deps,src: align ssize_t ABI between Node & nghttp2

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/nghttp2-ssize_t into master

Previously, we performed casts that are considered undefined behavior. Instead, just define ssize_t for nghttp2 the same way we define it for the rest of Node.

Also, remove a TODO comment that would probably also be technically correct but shouldn’t matter as long as nobody is complaining. (And is therefore unlikely to ever be implemented.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs/http2

CI: https://ci.nodejs.org/job/node-test-commit/15932/

Merge request reports