Skip to content

Revert "stream: defer readable and flow when sync"

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/revert-defer-readable into master

This reverts commit 563fff29 as it is causing failures in CITGM with dicer.

Refs: https://github.com/nodejs/node/pull/18515

The test case that was also fixed by https://github.com/nodejs/node/pull/18516 is being kept.

@mafintosh Could you take a look? If you can fix the failures without needing a revert, that would be amazing. But usually we are pretty fast to revert + open a new PR in these cases…

Example faillure:

~/src/dicer $ node test/test.js
assert.js:74
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: [test-multipart/Many parts]: Part #1 body mismatch
    at Dicer.<anonymous> (/home/xxxx/src/dicer/test/test-multipart.js:206:14)
    at Dicer.emit (events.js:136:15)
    at Dicer.emit (/home/xxxx/src/dicer/lib/Dicer.js:80:35)
    at PartStream.<anonymous> (/home/xxxx/src/dicer/lib/Dicer.js:212:18)
    at PartStream.emit (events.js:136:15)
    at endReadableNT (_stream_readable.js:1020:12)
    at process._tickCallback (internal/process/next_tick.js:91:19)

Merge request reports