Skip to content

src: do not redefine private for GenDebugSymbols

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/remove-private-redefine into master

Redefining private breaks any private inheritance in the included files. We can simply declare GenDebugSymbols() as friends in related classes to gain the access that we need.

Refs: https://github.com/nodejs/node/pull/14901#issuecomment-364210750

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports