Skip to content

test: add url type check in Module options

Rodrigo Muino Tomonari requested to merge github/fork/gideontee/vm-test-url into master

Hi. this is my first time contributing to an open source project. I'm a newbie here. From the Node.js Nightly Code Coverage, I noticed that the code coverage in root/internal/vm/Module.js lacked some test coverage for the url options parameter. The test just adds a check to ensure an error is thrown.

The change is a relatively small one. I took a look at the other lack of test areas for that file, but perhaps I'm not familiar with the codebase to know how to test those.

Any help would be appreciated.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports

Loading