Skip to content

test: formalize exposure of internal bindings

Rodrigo Muino Tomonari requested to merge github/fork/devsnek/internal-test-binding into master

moves exposed internalBindings to a single location with short guidelines on how to expose them and a warning for users should they come across it.

i would also like to take this opportunity to discuss if these tests are needed. traditionally it seems we rely on internals working by ensuring the behavior of the publicly facing apis that depend on them, but after there was a bug with module_wrap i was encouraged to create a test for it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Merge request reports