Skip to content

child_process: fix stdio sockets creation

Rodrigo Muino Tomonari requested to merge github/fork/santigimeno/fix_socket_creation_child into master

readable and writable properties can be passed directly to the net.Socket constructor. This change also avoids an unnecessary call to read(0) on the stdin socket. This behavior was disclosed when trying to merge libuv@1.19.0 and specifically this commit: https://github.com/libuv/libuv/commit/fd049399aa4ed8495928e375466970d98cb42e17.

Refs: https://github.com/libuv/libuv/pull/1655

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

Merge request reports