Skip to content

lib: remove some yoda statements

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/remove-yoda into master

This enables the yoda eslint rule and prohibits statements like false === variable. They are mainly historically and if someone would add a new one, I guess it would be complained about while reviewing. This makes that complain obsolete due to the lint rule.

I fixed the cases where this failed. Note: this is currently blocked by #18395 as that removes a lot of yoda statements as well. So I only removed the other cases here.

Update: I kept some yoda statements and removed the rule.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, benchmark, doc, test

Merge request reports