Skip to content

test: actually test tty getColorDepth()

Rodrigo Muino Tomonari requested to merge github/fork/Fishrock123/actually-test-tty-get-color-depth into master

TTY tests should almost never be placed in /parallel/. Skipping TTY tests there due to missing tty fds just means they will never be run, ever, on any system.

This moves the tty-get-color-depth test to /pseudo-tty/ where the test runner will actually make a pty fd.

Also moves getTTYfd() into common/index.js.

Edit: this was noticed by looking at the tty coverage.

cc @BridgeAR

CI: https://ci.nodejs.org/job/node-test-pull-request/13183/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, tty

Merge request reports