Skip to content

src: add nullptr check for session in DEBUG macro

Rodrigo Muino Tomonari requested to merge github/fork/danbev/http2_packed_setting_debug into master

Currenlty when configuring --debug-http2 test/parallel/test-http2-getpackedsettings.js will segment fault:

$ out/Debug/node test/parallel/test-http2-getpackedsettings.js
Segmentation fault: 11

This is happening because the settings is created with the Environment in PackSettings:

Http2Session::Http2Settings settings(env);

This will cause the session to be set to nullptr. When the init function is later called the expanded DEBUG_HTTP2SESSION macro will cause the segment fault when the session is dereferenced.

I'm not sure about what the proper solution is here as I'm not very familiar with the http2 code yet. Creating this so that others can provide some feedback.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, http2

Merge request reports