Skip to content

src: fix build with --with-lttng

Rodrigo Muino Tomonari requested to merge github/fork/simark/lttng-build into master

Building with --with-lttng hits a few issues.

  • There are missing parentheses in node_lttng_tp.h since

    src: lint node_lttng_tp.h f1d2792c

    This patch adds them.

  • The arraysize function in node_lttng.cc is not found. I included node_internals.h and added the node namespace (node::arraysize).

  • The -llttng-ust flag is passed when building the static library libnode.a, but it's actually when linking a final executable that it's required. I see that node can be built as a shared library as well, so maybe the flag is relevant in that case. But in the case where the intermediate library is a static one, it doesn't work. I am not familiar with node's build system, so I did not fix this one, I am fine with changing the generated Makefile by hand for now. But if somebody wants to take a look, it's of course very appreciated :).

Merge request reports