Skip to content

src: move http2 module to openssl builtin modules

Rodrigo Muino Tomonari requested to merge github/fork/danbev/move_http2_to_openssl_modules into master

Currently, the http2 module is listed in the standard modules list. This means that if configured --without-ssl it is still possible to use the module with process.binding('http2') without an error.

This commit moves http2 into the openssl list so that it is not loaded unless crypto support is available. Using it will result in "No such module: http2" error instead.

I realise that crypto is not required for http2, but I was under the impression that it is for node.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, http2

Merge request reports