Skip to content

[v9.x backport] build: add node_lib_target_name to cctest deps

Rodrigo Muino Tomonari requested to merge github/fork/danbev/backport-18576-9.x into v9.x-staging

Currently the cctest target depend on the node_core_target_name target. But it is the node_lib_target_name target that compiles the sources now which means that if a source file in src is updated the cctest executable will not be re-linked against it, but will remain unchanged. The code will still be compiled, just not linked which means that if you are debugging you'll not see the changes and also a warning will be displayed about this issue.

This commit changes the cctest target to depend on node_lib_target_name.

PR-URL: https://github.com/nodejs/node/pull/18576 Reviewed-By: Matheus Marchini matheus@sthima.com Reviewed-By: Yihong Wang yh.wang@ibm.com Reviewed-By: Gibson Fahnestock gibfahn@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports