Skip to content

[v9.x backport] src: fix GetCpuProfiler() deprecation warning

Rodrigo Muino Tomonari requested to merge github/fork/danbev/backport-18534-to-v9.x into v9.x-staging

Replace v8::Isolate::GetCpuProfiler() with v8::CpuProfiler::New() and cache the instance; creating and disposing an instance every loop tick is too expensive.

PR-URL: https://github.com/nodejs/node/pull/18534 Fixes: https://github.com/nodejs/node/issues/18039 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Merge request reports