Skip to content

http2: use original error for cancelling pending streams

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/http2-pending-cancel-keep-error into master

Previously, if session.destroy() was called with an error object, the information contained in it would be discarded and a generic ERR_HTTP2_STREAM_CANCEL would be used for all pending streams.

Instead, make the information from the original error object available.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs/http2

Merge request reports