Skip to content

http: prevent aborted event when request is complete

Rodrigo Muino Tomonari requested to merge github/fork/billywhizz/fix-http-client-aborted into master
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http

When socket is closed on a response for a request that is being piped to a stream there is a condition where aborted event will be fired to http client when socket is closing and the incomingMessage stream is still set to readable.

We need a check for request being complete and to only raise the 'aborted' event on the http client if we have not yet completed reading the response from the server.

Merge request reports