Skip to content

build: fix gocvr version used for coverage

Rodrigo Muino Tomonari requested to merge github/fork/mhdawson/fix-gcovr into master

Fix the gcovr version to a fixed version and use patches specific to that version. This avoids us being broken by changes in the gcovr repo. Using file name for patches specific to the version level will allow us to move up when necessary without breaking coverage for earlier versions of Node.js

This also reverts the logic back to what it was before the change we landed earlier this week as that works with the 3.4 version of gcovr which is the latest tagged version.

Marked as WIP as needs https://github.com/nodejs/build/pull/1162 to land first.

Checklist
  • [ X] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Merge request reports