Skip to content

[v9.x backport] http2: callback valid check before closing request

Rodrigo Muino Tomonari requested to merge github/fork/trivikr/backport-19061-to-v9.x into v9.x-staging

Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError

PR-URL: https://github.com/nodejs/node/pull/19061 Fixes: https://github.com/nodejs/node/issues/18855 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Shingo Inoue leko.noor@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports