Skip to content

[v9.x backport] deps: cherry-pick 15c0c3a8ba and 43e2fb1c3d from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/Flarna/backport-19200-to-v9.x into v9.x-staging

These changes avoid a busy wait loop in V8 CPU Profiler thread for windows (except for short intervals).

It would be good if this is also backported to Node.js v9 and LTS releases as this busy loop effectively disallows the use of CpuProfiler in Windows production setups.

Original commit message 15c0c3a8ba:

[profiler] use Sleep() on windows for long profile intervals.

See nodejs/diagnostics#170

R=franzih@chromium.org

Change-Id: Iecc3bb27707b0d2afbb23fd9823d5cd4d725be6e
Reviewed-on: https://chromium-review.googlesource.com/931102
Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51466}

Original commit message 43e2fb1c3d:

[profiler] fix sleeping on windows for long intervals.
R=franzih@chromium.org

Change-Id: I5717db794fc797e7c3b0b8f122ddb6dc0702a99e
Reviewed-on: https://chromium-review.googlesource.com/941126
Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51755}

Refs: nodejs/diagnostics#170 Refs: nodejs/node#19200 Refs: https://github.com/v8/v8/commit/15c0c3a8ba69d5b2cc521f7b380d59f76834eb53 Refs: https://github.com/v8/v8/commit/43e2fb1c3df10f01ecf8519b6835ca2c7377d1ca

Checklist

Merge request reports