Skip to content

async_hooks: remove async_wrap from async_hooks.js

Rodrigo Muino Tomonari requested to merge github/fork/danbev/async_hook_js_confinement into master

This commit removes the builtin async_wrap module from lib/async_hooks.js.

The motivation for this is that lib/async_hooks.js requires lib/internal/async_hooks which also binds async_wrap. Instead of lib/async_hooks.js also binding async_wrap it now only has to require the internal async_hooks and access it's exports.

There might be a very good reason for doing it the current way but the reason is not obvious to me. Hopefully someone can shed some light on this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports