Skip to content

module: skip preserveSymlinks for main

Rodrigo Muino Tomonari requested to merge github/fork/guybedford/main-skip-preserve-symlinks into master

The CommonJS module resolver specifically skips --preserveSymlinks for the main entry point into Node.

From discussion in https://github.com/nodejs/node/issues/19383, it seems like this should probably be carried over into the ES module resolver in order to ensure full backwards-compatibility.

The alternative here might be to have --preserveSymlinks act on the main in the CJS resolver too instead of this PR.

//cc @nodejs/modules

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports