Skip to content

[v8.x backport] deps: cherry-pick 596d55a from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/benjamn/backport-v8-gc-stress-segfault-fix into v8.x-staging

Analogous to this v9.x-staging PR submitted by @MylesBorins: https://github.com/nodejs/node/pull/19477

I can confirm this fixes https://github.com/nodejs/node/issues/19274 for the reproductions I've been using.

Original commit message:

Deoptimization and multithreading.

When using Lockers and Unlockers it is possible to create a
scenario where multiple threads point to the same optimized
code object. When that happens, if one of the threads triggers
deoptimization, then the stack replacement needs to happen in
the stacks of all threads.
With this CL, the deoptimizer visits all threads to do so.
The CL also adds three tests where V8 used to crash due to this
issue.

Bug: v8:6563
Change-Id: I74e9af472d4833aa8d13e579df45133791f6a503
Reviewed-on: https://chromium-review.googlesource.com/670783
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com>
Cr-Commit-Position: refs/heads/master@{#48060}

Refs: https://github.com/v8/v8/commit/596d55adf60ccea580692206acf2f02676e569b2

Merge request reports