Skip to content

[8.x] Backport 18513, 18694

Rodrigo Muino Tomonari requested to merge github/fork/ofrobots/backport-8-18513 into v8.x-staging

8.x backport of #18513, #18694. @nodejs/lts this probably requires extra scrutiny as it backports a semver-minor deprecation – because async_hooks is experimental – to an LTS release.

I don't have too strong feelings that the deprecation must be backported to 8.x, but the rest of the commit (addition of the runInAsyncScope API) would be good to backport so that users have a consistent async_hooks API available across node versions. I'd be open to dropping the deprecation, if people feel strongly.

There are very few, but non-zero, users of the async hooks embedder API at this point.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/13814/

Merge request reports