Skip to content

[v8.x backport] 16390, 18547, 17296 (internet test flake fixes)

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/backport-17296-to-v8.x into v8.x-staging

test: introduce test/common/internet.addresses

This commit introduces test/common/internet.address, which includes a set of addresses for doing internet tests. These addresses can be overriden using NODE_TEST_* environment variables.

test: use internet.addresses in internet tests

PR-URL: https://github.com/nodejs/node/pull/16390

test: do not check TXT content in test-dns-any

google.com added another TXT record which broke this test. This removes the check on the content of the TXT record since that depends on an external state subject to change.

PR-URL: https://github.com/nodejs/node/pull/18547

test: add common.dns.errorLookupMock

test: mock the lookup function in parallel tests

These tests should not make any DNS calls. The lookup would fail when the DNS requests are hijacked and time out instead of erroring out.

PR-URL: https://github.com/nodejs/node/pull/17296 Refs: https://github.com/nodejs/help/issues/687

Merge request reports