Skip to content

Fix error enumerablility

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/fix-error-enumerablility into master
  1. Commit:

A error message should always be non-enumerable. This makes sure that is true for dns errors as well. It also adds another check in common.expectsError to make sure no other regressions are introduced going forward.

Fixes: #19716 (closed)

2. Commit:

Right now the hostname could in some cases be missed, depending on the libuv error number. This makes sure there the hostname is always added, if available.

Update: I removed the second commit to another PR so it is easier for backporting.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports