Skip to content

build,windows: make vcbuild fail if upload fails

Rodrigo Muino Tomonari requested to merge github/fork/refack/vbcuild-fail-with-ssh into master

Refs: https://github.com/nodejs/build/issues/1211

Crood solution but effective.

Output before:

d:\code\node$ vcbuild nobuild noprojgen upload
Looking for Python 2.x
ssh: Could not resolve hostname node-www: Name or service not known
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known
lost connection
ssh: Could not resolve hostname node-www: Name or service not known

Output after:

d:\code\node$ vcbuild nobuild noprojgen upload
Looking for Python 2.x
ssh: Could not resolve hostname node-www: Name or service not known
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes — manual
  • commit message follows commit guidelines

Merge request reports