Skip to content

src: rename ERR_STRING_TOO_LARGE to ERR_STRING_TOO_LONG

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/string-too-long into master

The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users.

Refs: https://github.com/nodejs/node/pull/19739

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports