Skip to content

assert: detect faulty throws usage

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/improve-wrong-throws-usage into master

This is a attempt in fixing the ambiguous behavior of the assert.throws message. It is the best way to detect it out of my perspective. This ambiguity is the only real problem with the current API. It would of course be nicer if this would have always tested for the error message but changing that is not possible because quite some code will rely on the current behavior.

The PR currently relies on #19865 to prevent conflicts after landing that PR. I am going to remove that commit as soon as that lands. Done.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports