Skip to content

test: add Buffer slice UTF-8 test

Rodrigo Muino Tomonari requested to merge github/fork/Trott/utf8-buffer-slice into master

Gets rid of another TODO comment in the tests.

Thing is, I'm not sure this is really needed. There seem to be things in other places in this test file that would trigger utf8Slice(), at least on casual inspection.

So...@chrisdickinson: I know you ran some code coverage analysis recently. Any chance you could run code coverage on just the one file that's changed here and compare it to the results with the version in master to see if this change results in slightly more coverage? Or point me at the code coverage tool you used and I'll try to get up and running with it to do this myself?

Merge request reports