Skip to content

test: remove expectations based on v8 headers from types test

Rodrigo Muino Tomonari requested to merge github/fork/devsnek/unbreak-v8-ci into master

cc @addaleax

if v8 adds any new type checks this breaks their CI until node updates, so i think its just safer to just remove this check

check out https://logs.chromium.org/v/?s=v8%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8949374903458528112%2F%2B%2Fsteps%2Fbuild_addons_and_test_node.js%2F0%2Fstdout

blocking https://chromium-review.googlesource.com/c/v8/v8/+/1011762

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports

Loading