Skip to content

test: fix test-child-process-send-returns-boolean

Rodrigo Muino Tomonari requested to merge github/fork/Trott/fix-send into master

test-child-process-send-returns-boolean was unreliable in CI and locally.

  • use 'SIGKILL' for more reliable process termination
  • replace callback with assert.ifError()
  • increase interval in fixture from 500ms to 9999ms. It's only purpose is to keep the process from exiting.

Fixes: https://github.com/nodejs/node/issues/20135

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports