build: require --openssl-no-asm if no suitable assemble on x86_64 and ia32 (!20226) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/shigeki/strict_asm_checks into master Apr 23, 2018

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
[] tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This is a copy of https://github.com/nodejs/node/pull/20217#pullrequestreview-114394538 and add an additional commit to limit assembler check only on x86_64 and ia32 and BUILDING.md updates.

I submit a new PR with fast-track for only 5 hours left to land semver-major on Node-v10.0.0 until PST noon as described in https://github.com/nodejs/node/pull/20217#issuecomment-383563211.

Fixes: https://github.com/nodejs/node/issues/19944 Refs: https://github.com/nodejs/node/pull/20217

@rvagg @mhdawson @danbev @jasnell @bnoordhuis @nodejs/build @nodejs/tsc