Skip to content

build: do not depend on `cp` in `PATH`

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/build-windows-copy into master

Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on Windows, but this is an easier fix (at least for me) than figuring out how to get cp into the PATH in all cases, and judging from the issue I’m not the only one who ran into this.

Fixes: https://github.com/nodejs/node/issues/20272

/cc @fs-eire

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports