Skip to content

deps: cherry-pick 76cab5f from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/targos/fix-20278 into master

Original commit message:

Fix Object.entries/.values with non-enumerable properties

Iterate over all descriptors instead of bailing out early and missing
enumerable properties later.

Bug: chromium:836145
Change-Id: I104f7ea89480383b6b4b9204942a166bdf8e0597
Reviewed-on: https://chromium-review.googlesource.com/1027832
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52786}

Refs: https://github.com/v8/v8/commit/76cab5ff786bea157a6931296924384a2242da93 Fixes: https://github.com/nodejs/node/issues/20278

The merge to 6.6 was rejected in https://bugs.chromium.org/p/chromium/issues/detail?id=836145#c31.

/cc @nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports