Skip to content

src: remove `kFlagNoShutdown` flag

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/no-has-shutdown-flag into master

This was originally introduced in 3446ff41, in order to fix a hard crash. However, since the libuv 1.18.0 update, that hard crash is gone, and since f2b9805f we do not throw an error in JS land anymore either, rendering the flag unnecessary.

Also, the original test that checked this condition was added to test/parallel/. Since that typically runs without a TTY stdin, a duplicate test is being added to the pseudo-tty test suite in this commit.

Refs: https://github.com/nodejs/node/commit/3446ff417ba1e11d35d1661b8788eac5af029360 Refs: https://github.com/nodejs/node/commit/f2b9805f85d3ff770892b37944a0890e0e60ca78 Refs: https://github.com/libuv/libuv/commit/0e2814179c9903423d058b095e84f48fcfb8f3d1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports