Skip to content

url: call `onParsePortComplete` on null port from `onParseHostComplete`

Rodrigo Muino Tomonari requested to merge github/fork/AyushG3112/fix-url-port-host into master

Call onParsePortComplete on null port from onParseHostComplete to set url’s port to null, if port is url’s scheme’s default port, and to port otherwise, as specified in the spec.

Also, trim all trailing : from host in the setter to fix regressions caused by the change.

Refs: https://url.spec.whatwg.org/#port-state Fixes: https://github.com/nodejs/node/issues/20465

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports