src: minor refactor to string_search.h

• Use std::max instead of a custom variant
• Use member method pointers to avoid an extra layer of indirection
• Stop transferring Vector into the node namespace

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines