Skip to content

fs: improve fchmod{Sync} validation

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/modes into master

This commit removes the check for mode > 0o777. It also validates the inputs as int32s instead of uint32s, because they are ints in the binding layer. Range validation is also added to the internal validators.

Fixes: https://github.com/nodejs/node/issues/20498

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports