Skip to content

net,http2: refactor _write and _writev in net.Socket and http2.Http2Stream

Rodrigo Muino Tomonari requested to merge github/fork/ryzokuken/refactor-stream-write into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Roadmap

  • Remove inconsistencies between http2.Http2Stream._write and http2.Http2Stream._writev
  • Move all logic into a new method http2.Http2Stream._writeGeneric
  • Remove inconsistencies between net.Socket._writeGeneric and http2.Http2Stream._writeGeneric
  • Refactor common logic into a method in the base class/method, possibly writeGeneric from internal/stream_base_commons.

/cc @addaleax @nodejs/http2 @nodejs/net

Merge request reports