Skip to content

test: add eslint rule to verify assertion input

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/add-assert-order-rule into master

The input for assert.deepStrictEqual and similar expect the actual input first and the expected input as second argument. This verifies that this is actually done correct in our tests.

This is important so the possible error message actually makes sense.

assert.strictEqual produces around 600 errors and I am not sure if we really want to activate such a rule for them right now even though the input is wrong. Any opinions?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports