Skip to content

[v8.x] http2: pass session to DEBUG_HTTP2SESSION2

Rodrigo Muino Tomonari requested to merge github/fork/danbev/http2_debug_issue_8.11.2 into v8.x-staging

When configure with --debug-http2 --debug-nghttp2 the following compilation error is generated:

DEBUG_HTTP2SESSION2(this, "fatal error receiving data: %d", ret);
                    ^
../src/node_http2.cc:1690:27:
error: invalid use of 'this' outside of a non-static member function

1 errors generated.

OnStreamReadImpl is static and I think the intention was to pass in the session variable here.

Refs: https://github.com/nodejs/node/issues/20806

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports