Skip to content

Revert "test: reduce runtime"

Rodrigo Muino Tomonari requested to merge github/fork/Trott/rebert-er-revert into master

This reverts commit 352ae239.

The commit appears to have introduced unreliability in one of the two refactored tests in AIX in CI (see https://github.com/nodejs/node/pull/20688#issuecomment-391496800) and macOS (see https://github.com/nodejs/node/issues/20888).

Not looking to fast track this or anything (unless this becomes more of a problem for people). Just want it opened in case this is still an issue in 48 hours. The benefits of the change are small (and might be offset by unintentional slow-down on some platforms, see https://github.com/nodejs/node/pull/20688#issuecomment-391584196).

/cc @danbev @MylesBorins @BridgeAR @nodejs/testing

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

Merge request reports