Skip to content

assert: reverse diff direction

Rodrigo Muino Tomonari requested to merge github/fork/ryzokuken/assert-20897 into master

The current direction for the assert diffs is rather peculiar. While it’s not the “wrong” way to do it per-se, it’s definitely inconsistent with the ecosystem and is rather unintuitive.

This PR aims to fix that by reversing the direction.

Fixes: https://github.com/nodejs/node/issues/20897

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @BridgeAR @addaleax @targos

Merge request reports