Skip to content

test: improve path tests

Rodrigo Muino Tomonari requested to merge github/fork/Shivang44/test-path-update into master

Replaced deepStrictEqual with strictEqual when asserting that the path is equal to the win32 or posix equivalent, since it is a more strict check than deepStrictCheck. Also removed third argument in the check so that if there is an assertion error the properties that are different will be displayed.

Note: Credits to Rich Trott from nodetodo.org helping me find this first contribution to work on.

Checklist
  • make -j4 test (UNIX)

Note: One of the tests is crashing right when I clone and run make -j4 test before making any changes. I believe this is specific to my machine and unrelated to this PR:

=== release test-zlib.zlib-binding.deflate === Path: async-hooks/test-zlib.zlib-binding.deflate Command: out/Release/node /home/shivang/oss/node/test/async-hooks/test-zlib.zlib-binding.deflate.js --- CRASHED (Signal: 11) ---

Merge request reports