Skip to content

test: fix flaky test-domain-timers

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-test-domain-timers into master

It's possible for this test to be (extremely infrequently) flaky if 1ms (which due to rounding in libuv could be far less, actually) or more elapses between setting the two timeouts. In that case, the second timer will not fire and the test will fail.

This failed recently in https://ci.nodejs.org/job/node-test-commit-linuxone/1701/nodes=rhel72-s390x/testReport/junit/(root)/test/parallel_test_domain_timers/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports