Skip to content

test,benchmark: have benchmark tests confirm that only one line of output is generated per benchmark file

Rodrigo Muino Tomonari requested to merge github/fork/Trott/berlin-7 into master

This required:

  • changing benchmark tests that produced more than one line of output per benchmark file to only produce one (which is what we've always wanted anyway)

  • add a build step to MakeFile to make sure that delete the misc/function_calls benchmark will work; /cc @nodejs/build

  • make it so the benchmark test module checks the output to make sure each file only produces one line of results

Whoops, just realized I forgot to add the build step to vcbuild.bat. Marking as in progress for the moment until I fix that. (If someone wants to add a commit to the branch to do that, feel free to beat me to it. That would be awesome.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports