build: fail on instrumentation errors
nyc was silently failing to instrument new language features, resulting in a failure to instrument console.js.
the actual underlying issues are discussed and addressed here:
https://github.com/babel/babel/issues/8075, https://github.com/istanbuljs/istanbuljs/pull/174, https://github.com/istanbuljs/istanbuljs/pull/175
In this pull request we enable nyc's logging and new "exit on failure" feature to ensure that we catch behavior like this immediately in the future.
see #20952 (closed)
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
commit message follows commit guidelines
CC: @BridgeAR, @maclover7