Skip to content

[v8.x fix] - stream: fix end not being called when reading some base64 files

Rodrigo Muino Tomonari requested to merge github/fork/marcosc90/fix-19862 into v8.x

This fixes 'end' not being called when reading base64 files with highWaterMark equal to: file length - 1, and fixes 'data' not being called on some edge cases when highWaterMark was lower than file length.

Fixes: https://github.com/nodejs/node/issues/19862

This issue is still present in v6.x & v9.x so if everything is ok, I'll submit changes for those versions too.

Going through master history, the same line of code was changed in this commit

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports