Skip to content

test: remove postmortem test from flaky list

Rodrigo Muino Tomonari requested to merge github/fork/Trott/postmortem into master

test-postmortem-metadata does not ever seem to fail on master. According to Michaël Zasso, when it fails locally for him during a V8 upgrade, he pings Colin Ihrig who fixes it almost immediately.

There was some discussion about marking it flaky when it first landed but it's not clear to me that it is necessary. (We can always mark it flaky again if it turns out that it is necessary.)

The reason I want this test removed from the status file for flaky tests is that I believe that file can and should be used as a list of tests to fix. But this test doesn't need any fixing.

Refs: https://github.com/nodejs/node/pull/17685

@bnoordhuis @cjihrig @targos @nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports